Re: [PATCH v3 0/4] platform/x86: acer-wmi: Add fan control support

[Armin Wolf]

Am 16.10.25 um 19:23 schrieb Fa-Iz Faadhillah Ibrahim:

> On Thursday, October 16, 2025 2:25 AM Armin Wolf wrote:
> > This patch series aims to add fan control support to the acer-wmi
> > driver. The patches are compile-tested only and need to be tested
> > on real hardware to verify that they actually work.
> >
> > I CCed three users who requested support for this feature. I would be
> > very happy if one of you could test those patches and report back.
> >
> > Changes since v2:
> > - get rid of nested bit masks
> >
> > Changes since v1:
> > - remove unnecessary blank line
> >
> > Changes since RFC v2:
> > - improve error handling when setting fan behavior
> > - Add Reviewed-by tags
> > - whitelist PHN16-72
> >
> > Changes since RFC v1:
> > - remove duplicate include and replace hwmon_pwm_mode with
> >    hwmon_pwm_enable in second patch
> >
> > Armin Wolf (4):
> >    platform/x86: acer-wmi: Fix setting of fan behavior
> >    platform/x86: acer-wmi: Add fan control support
> >    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
> >    platform/x86: acer-wmi: Add support for PHN16-72
> >
> >   drivers/platform/x86/acer-wmi.c | 292 +++++++++++++++++++++++++++++---
> >   1 file changed, 269 insertions(+), 23 deletions(-)
> Hello,
>
> I've tested the patch on my PHN16-72, this time the fan control for CPU fan
> works just fine, but GPU fan control doesn't work anymore. no logs observed on
> dmesg while changing the speed of either fan.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim
It seems that i made a small error in WMID_gaming_set_fan_behavior(). I send a v4 patch series
with the necessary fix.

Thanks,
Armin Wolf