Re: [PATCH] wifi: wcn36xx: Remove unused wcn36xx_smd_update_scan_params

[Dr. David Alan Gilbert]

* Jeff Johnson (jeff.johnson@xxxxxxxxxxxxxxxx) wrote:
> On 10/9/2025 3:15 PM, Loic Poulain wrote:
> > Hi Jeff,
> > 
> > On Thu, Oct 9, 2025 at 5:25 PM Dr. David Alan Gilbert <linux@xxxxxxxxxxx> wrote:
> >>
> >> * Loic Poulain (loic.poulain@xxxxxxxxxxxxxxxx) wrote:
> >>> On Thu, Jun 19, 2025 at 3:05 AM <linux@xxxxxxxxxxx> wrote:
> >>>>
> >>>> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> >>>>
> >>>> wcn36xx_smd_update_scan_params() last use was removed in 2020 by
> >>>> commit 5973a2947430 ("wcn36xx: Fix software-driven scan")
> >>>>
> >>>> Remove it.
> >>>>
> >>>> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>
> >>>
> >>> Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>
> >>
> >> Hi Loic,
> >>   Is this getting into a pull somewhere?
> > 
> > Can it be picked for ath10-next?
> 
> This was not on my radar since it wasn't sent to linux-wireless and hence
> isn't tracked in patchwork. I just looked at it and it seems the following are
> now also unused and could be removed:
> struct wcn36xx_hal_update_scan_params_resp
> struct wcn36xx_hal_update_scan_params_req_ex

Oh, I'm happy to cook a v2 for that if Loic agrees they should go
(I know some drivers like to keep struct definitions if they document the hardware)

> Let me know if you want me to take this as-is or wait for a v2. If you send a
> v2 please also include linux-wireless so that it is tracked by patchwork.

Sure.

Note that linux-wireless isn't included in get_maintainer output for this:

$ scripts/get_maintainer.pl -f drivers/net/wireless/ath/wcn36xx/smd.c
Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx> (maintainer:QUALCOMM WCN36XX WIRELESS DRIVER)
wcn36xx@xxxxxxxxxxxxxxxxxxx (open list:QUALCOMM WCN36XX WIRELESS DRIVER)
linux-kernel@xxxxxxxxxxxxxxx (open list)
QUALCOMM WCN36XX WIRELESS DRIVER status: Supported

Dave

> /jeff
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/