Re: [PATCH v2 01/15] net: rnpgbe: Add build support for rnpgbe

[Andrew Lunn]

> > > +#include <linux/types.h>
> > > +#include <linux/module.h>
> > > +#include <linux/pci.h>
> > > +#include <linux/netdevice.h>
> > > +#include <linux/string.h>
> > > +#include <linux/etherdevice.h>
> > 
> > It is also reasonably normal to sort includes.
> > 
> 
> Got it, I will also check all other files. But what rules should be
> followed? General to specific?

All global imports first, and then local.

    Andrew