Re: [PATCH] lib/xxhash: Comment out unused functions

[Dr. David Alan Gilbert]

* Christoph Hellwig (hch@xxxxxxxxxxxxx) wrote:
> On Mon, Jul 14, 2025 at 01:09:27AM +0100, linux@xxxxxxxxxxx wrote:
> > From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
> > 
> > xxh32_digest() and xxh32_update() were added in 2017 in the original
> > xxhash commit, but have remained unused.
> > 
> > While I've mostly been deleting unused functions, this is a general
> > library and I see erofs is using other bits of xxh32, so it didn't
> > seem right just to delete them.
> > 
> > Comment them out with #if 0.
> > (Which checkpatch rightly warns about)
> 
> Please just remove it like all other dead code.  The same argument
> that folks can easily look at the git history to resurrect it applies
> here as everywhere else.

Hmm OK, as requested, v2 posted:

Subject: [PATCH v2] lib/xxhash: Remove unused functions
Date: Wed, 16 Jul 2025 14:32:45 +0100
Message-ID: <20250716133245.243363-1-linux@xxxxxxxxxxx>

Dave
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/