RE: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check

[Peng Fan]

> Subject: [PATCH 1/1] ASoC: codec: tlv320aic32x4: Fix reset GPIO check
> 
> rstn_gpio being a GPIO descriptor the check is wrong (inverted) for
> releasing the reset of the codec.
> 
> Fixes: 790d5f8ee6f2 ("ASoC: codec: tlv320aic32x4: Convert to GPIO
> descriptors")
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> ---
> AFAICT this bug was introduced on v2 of the series which changed the
> validity check
> 
>  sound/soc/codecs/tlv320aic32x4.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/tlv320aic32x4.c
> b/sound/soc/codecs/tlv320aic32x4.c
> index 3b89980e9bcf2..7399080f8580c 100644
> --- a/sound/soc/codecs/tlv320aic32x4.c
> +++ b/sound/soc/codecs/tlv320aic32x4.c
> @@ -1388,7 +1388,7 @@ int aic32x4_probe(struct device *dev, struct
> regmap *regmap,
>  		return ret;
>  	}
> 
> -	if (!aic32x4->rstn_gpio) {
> +	if (aic32x4->rstn_gpio) {

Oops! Thanks for spotting this.

Reviewed-by: Peng Fan <peng.fan@xxxxxxx>