Re: [PATCH net-next v7 04/15] net: phy: Introduce PHY ports representation
From: Dan Carpenter
Date: Mon Jul 14 2025 - 15:08:41 EST
Hi Maxime,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/dt-bindings-net-Introduce-the-ethernet-connector-description/20250630-224035
base: net-next/main
patch link: https://lore.kernel.org/r/20250630143315.250879-5-maxime.chevallier%40bootlin.com
patch subject: [PATCH net-next v7 04/15] net: phy: Introduce PHY ports representation
config: x86_64-randconfig-r071-20250706 (https://download.01.org/0day-ci/archive/20250706/202507061812.0aBYBa9l-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14+deb12u1) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202507061812.0aBYBa9l-lkp@xxxxxxxxx/
smatch warnings:
drivers/net/phy/phy_port.c:130 phy_port_get_type() warn: bitwise AND condition is false here
vim +130 drivers/net/phy/phy_port.c
055cbf51317b1e Maxime Chevallier 2025-06-30 122 /**
055cbf51317b1e Maxime Chevallier 2025-06-30 123 * phy_port_get_type() - get the PORT_* attribut for that port.
055cbf51317b1e Maxime Chevallier 2025-06-30 124 * @port: The port we want the information from
055cbf51317b1e Maxime Chevallier 2025-06-30 125 *
055cbf51317b1e Maxime Chevallier 2025-06-30 126 * Returns: A PORT_XXX value.
055cbf51317b1e Maxime Chevallier 2025-06-30 127 */
055cbf51317b1e Maxime Chevallier 2025-06-30 128 int phy_port_get_type(struct phy_port *port)
055cbf51317b1e Maxime Chevallier 2025-06-30 129 {
055cbf51317b1e Maxime Chevallier 2025-06-30 @130 if (port->mediums & ETHTOOL_LINK_MEDIUM_BASET)
^^^^^^^^^^^^^^^^^^^^^^^^^
I think BIT(ETHTOOL_LINK_MEDIUM_BASET) was intended.
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki