Re: [RFC PATCH v8 15/35] x86/apic: Unionize apic regs for 32bit/64bit access w/o type casting

From: Sean Christopherson
Date: Mon Jul 14 2025 - 09:37:30 EST


On Sat, Jul 12, 2025, Borislav Petkov wrote:
> On Sat, Jul 12, 2025 at 10:38:08PM +0530, Neeraj Upadhyay wrote:
> > It was more to imply like secure APIC-page rather than Secure-APIC page. I will change
> > it to secure_avic_page or savic_apic_page, if one of these looks cleaner. Please suggest.
>
> If the page belongs to the guest's secure AVIC machinery then it should be
> called secure_avic_page to avoid confusion. Or at least have a comment above
> it explaining what it is.

secure_avic_page works for me. I have no real opinion on the name, I suggested
prepending "secure" purely to avoid creating a too-generic "struct apic_page".