Re: [PATCH] firewire: ohci: reduce the size of common context structure by extracting members into AT structure
From: Takashi Sakamoto
Date: Sat Jul 12 2025 - 09:00:26 EST
On Thu, Jul 10, 2025 at 10:19:16PM +0900, Takashi Sakamoto wrote:
> In commit 386a4153a2c1 ("firewire: ohci: cache the context run bit"), a
> running member was added to the context structure to cache the running
> state of a given DMA context. Although this member is accessible from IR,
> IT, and AT contexts, it is currently used only by the AT context.
>
> Additionally, the context structure includes a work item, which is also
> used by the AT context. Both members are unnecessary for IR and IT
> contexts.
>
> This commit refactors the code by moving these two members into a new
> structure specific to AT context.
>
> Signed-off-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> ---
> drivers/firewire/ohci.c | 92 ++++++++++++++++++++++-------------------
> 1 file changed, 49 insertions(+), 43 deletions(-)
Applied to for-next branch.
Thanks
Takashi Sakamoto