Re: [PATCH v2 2/2] drm: rust: rename as_ref() to from_raw() for drm constructors

[Benno Lossin]

On Fri Jul 11, 2025 at 10:04 AM CEST, Alice Ryhl wrote:
> The prefix as_* should not be used for a constructor. Constructors
> usually use the prefix from_* instead.
>
> Some prior art in the stdlib: Box::from_raw, CString::from_raw,
> Rc::from_raw, Arc::from_raw, Waker::from_raw, File::from_raw_fd.
>
> There is also prior art in the kernel crate: cpufreq::Policy::from_raw,
> fs::File::from_raw_file, Kuid::from_raw, ARef::from_raw,
> SeqFile::from_raw, VmaNew::from_raw, Io::from_raw.
>
> Link: https://lore.kernel.org/r/aCd8D5IA0RXZvtcv@pollux
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

Reviewed-by: Benno Lossin <lossin@xxxxxxxxxx>

---
Cheers,
Benno

> ---
>  rust/kernel/drm/device.rs  |  2 +-
>  rust/kernel/drm/file.rs    |  8 ++++----
>  rust/kernel/drm/gem/mod.rs | 16 ++++++++--------
>  rust/kernel/drm/ioctl.rs   |  4 ++--
>  4 files changed, 15 insertions(+), 15 deletions(-)