Re: [PATCH] drm/amdgpu: Fix lifetime of struct amdgpu_task_info after ring reset

From: André Almeida
Date: Thu Jul 10 2025 - 17:48:08 EST


Em 04/07/2025 00:06, André Almeida escreveu:
When a ring reset happens, amdgpu calls drm_dev_wedged_event() using
struct amdgpu_task_info *ti as one of the arguments. After using *ti, a
call to amdgpu_vm_put_task_info(ti) is required to correctly track its
lifetime.

However, it's called from a place that the ring reset path never reaches
due to a goto after drm_dev_wedged_event() is called. Move
amdgpu_vm_put_task_info() bellow the exit label to make sure that it's
called regardless of the code path.

amdgpu_vm_put_task_info() can only accept a valid address or NULL as
argument, so initialise *ti to make sure we can call this function if
*ti isn't used.

Fixes: a72002cb181f ("drm/amdgpu: Make use of drm_wedge_task_info")
Reported-by: Dave Airlie <airlied@xxxxxxxxx>
Closes: https://lore.kernel.org/dri-devel/CAPM=9tz0rQP8VZWKWyuF8kUMqRScxqoa6aVdwWw9=5yYxyYQ2Q@xxxxxxxxxxxxxx/
Signed-off-by: André Almeida <andrealmeid@xxxxxxxxxx>
---

This patch is now merged at drm-misc-next, thanks!