Re: [PATCH] ASoC: SDCA: fix HID dependency
From: Arnd Bergmann
Date: Wed Jul 09 2025 - 11:16:58 EST
On Wed, Jul 9, 2025, at 17:04, Charles Keepax wrote:
> On Wed, Jul 09, 2025 at 03:36:49PM +0200, Arnd Bergmann wrote:
>> On Wed, Jul 9, 2025, at 14:38, Charles Keepax wrote:
>> > On Tue, Jul 08, 2025 at 08:46:06PM +0200, Arnd Bergmann wrote:
>> It could work, but then the 'depends on HID || !HID' would
>> need to be under SND_SST_ATOM_HIFI2_PLATFORM_ACPI and anything
>> else that might select SND_SOC_ACPI_INTEL_MATCH,
>> SND_SOC_ACPI_INTEL_SDCA_QUIRKS, or SND_SOC_SDCA in the future.
>
> Ah yes I forgot things are selected by the Intel stuff, at least
> the double depends on HID can be changed though? ie.
>
> depends on SND_SOC_SDCA
> depends on HID=y || HID=SND_SOC_SDCA
Yes, that functionally the same, I wasn't sure which one
you'd prefer. Let me know if I should send a v2.
Arnd