Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document

[Hailong Fan (范海龙)]

On Thu, 2025-07-03 at 11:05 +0200, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Il 03/07/25 10:08, Krzysztof Kozlowski ha scritto:
> > On 03/07/2025 09:56, hailong.fan wrote:
> > > From: Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > > 
> > > This patch adds mt8196 dsp document. The dsp is used for Sound
> > > Open
> > 
> > Please do not use "This commit/patch/change", but imperative mood.
> > See
> > longer explanation here:
> > 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst*L95__;Iw!!CTRNKA9wMg0ARbw!g39q48fUCsDJ5PETUtQ0PK0Bkwf0Ce1F_ZzJiEiWMzuybWQ0dSPzblvLlJ-4saWTSoJWuS5imsXbpdgLBvUy4wxw9C5w7B4m$
> > 
> > > Firmware driver node. It includes registers,  clocks, memory
> > > regions,
> > > and mailbox for dsp.
> > > 
> > > Signed-off-by: Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > > ---
> > >   .../bindings/sound/mediatek,mt8196-dsp.yaml   | 95
> > > +++++++++++++++++++
> > >   1 file changed, 95 insertions(+)
> > >   create mode 100644
> > > Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > dsp.yaml
> > > b/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > dsp.yaml
> > > new file mode 100644
> > > index 000000000000..68f594f476e8
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > > dsp.yaml
> 
> Wrong folder; this should go to dsp/mediatek,mt8196-dsp.yaml ....
> 
> ...but then I don't get why MT8196 wasn't simply added to
> mediatek,mt8186-dsp.yaml.
> 
Yes, the first version was written this way, but the maintainer
suggested the following, so I'm not sure which approach is more
appropriate. Could you please provide a final recommendation?
 
v1 link: 
https://lore.kernel.org/all/a72988212d0d95bfe76eb9c53bbdb8c57c989377.camel@xxxxxxxxxxxx/
 
comment:
>
> > ---
> >  .../bindings/dsp/mediatek,mt8196-dsp.yaml     | 96
> > +++++++++++++++++++
>
> Don't grow dsp directory. Either this is remoteproc or some sound
> component, so place it accordingly.
This is a reference to the approach used in a previous MediaTek
project:
 

https://web.git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp
Do we need to move all the files under the DSP directory to the sound
directory?

> > > @@ -0,0 +1,95 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: 
> > > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8196-dsp.yaml*__;Iw!!CTRNKA9wMg0ARbw!g39q48fUCsDJ5PETUtQ0PK0Bkwf0Ce1F_ZzJiEiWMzuybWQ0dSPzblvLlJ-4saWTSoJWuS5imsXbpdgLBvUy4wxw9GN4ryBQ$
> > > +$schema: 
> > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!g39q48fUCsDJ5PETUtQ0PK0Bkwf0Ce1F_ZzJiEiWMzuybWQ0dSPzblvLlJ-4saWTSoJWuS5imsXbpdgLBvUy4wxw9NKbMuhN$
> > > +
> > > +title: MediaTek mt8196 DSP core
> > > +
> > > +maintainers:
> > > +  - Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > > +
> > > +description: The MediaTek mt8196 SoC mt8196 contain a DSP core
> > > used for advanced
> > 
> > Missing blank line. Look at other bindings. Also does not look
> > wrapped
> > at 80 (see Linux coding style doc).
> > 
> 
> There's also a typo, "mt8196 SoC mt8196"
> 
Will update in next version, thanks.

> > 
> > > +  pre- and post- audio processing.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: mediatek,mt8196-dsp
> > > +
> > > +  reg:
> > > +    items:
> > > +      - description: DSP configuration registers
> > > +      - description: DSP SRAM
> > > +      - description: DSP secure registers
> > > +      - description: DSP bus registers
> > > +
> > > +  reg-names:
> > > +    items:
> > > +      - const: cfg
> > > +      - const: sram
> > > +      - const: sec
> > > +      - const: bus
> > > +
> > > +  clocks:
> > > +    items:
> > > +      - description: mux for dsp clock
> > > +      - description: 26M clock
> > > +      - description: ADSP PLL clock
> > > +
> > > +  clock-names:
> > > +    items:
> > > +      - const: adsp_sel
> > 
> > Isn't this called audiodsp in other bindings?
> > 
> > > +      - const: clk26m
> > 
> > Don't use frequencies. How is the pin or input called in datasheet?
> > How
> > other devices call it?
> 
> In the datasheet, this is called.... CLK26M (really).
> 
> Cheers,
> Angelo
> 
> > 
> > > +      - const: adsppll
> > > +
> > > +  power-domains:
> > > +    maxItems: 1
> > > +
> > 
> > Best regards,
> > Krzysztof
> 
>