Re: [PATCH v2 1/2] dt-bindings: dsp: mediatek: add mt8196 dsp document

[Hailong Fan (范海龙)]

On Thu, 2025-07-03 at 10:08 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 03/07/2025 09:56, hailong.fan wrote:
> > From: Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > 
> > This patch adds mt8196 dsp document. The dsp is used for Sound Open
> 
> Please do not use "This commit/patch/change", but imperative mood.
> See
> longer explanation here:
> 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst*L95__;Iw!!CTRNKA9wMg0ARbw!mhCB8cQ9NY4AztdErJWay3VtFNHSe89i00TgGeTd62W6m-Ios46XeDaYqM0QQ7m4SHjlNw69PvU7T9M$
> 
Okay, will be updated to:
Add device tree binding documentation for the
MediaTek MT8196 DSP. The DSP is used by the Sound Open Firmware driver
node and includes registers, clocks, memory regions, and a mailbox for
DSP communication.
 
Thanks.

> > Firmware driver node. It includes registers,  clocks, memory
> > regions,
> > and mailbox for dsp.
> > 
> > Signed-off-by: Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > ---
> >  .../bindings/sound/mediatek,mt8196-dsp.yaml   | 95
> > +++++++++++++++++++
> >  1 file changed, 95 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml
> > b/Documentation/devicetree/bindings/sound/mediatek,mt8196-dsp.yaml
> > new file mode 100644
> > index 000000000000..68f594f476e8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-
> > dsp.yaml
> > @@ -0,0 +1,95 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://urldefense.com/v3/__http://devicetree.org/schemas/sound/mediatek,mt8196-dsp.yaml*__;Iw!!CTRNKA9wMg0ARbw!mhCB8cQ9NY4AztdErJWay3VtFNHSe89i00TgGeTd62W6m-Ios46XeDaYqM0QQ7m4SHjlNw697qH1t6A$
> > +$schema: 
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!mhCB8cQ9NY4AztdErJWay3VtFNHSe89i00TgGeTd62W6m-Ios46XeDaYqM0QQ7m4SHjlNw69EdDHgNY$
> > +
> > +title: MediaTek mt8196 DSP core
> > +
> > +maintainers:
> > +  - Hailong Fan <hailong.fan@xxxxxxxxxxxx>
> > +
> > +description: The MediaTek mt8196 SoC mt8196 contain a DSP core
> > used for advanced
> 
> Missing blank line. Look at other bindings. Also does not look
> wrapped
> at 80 (see Linux coding style doc).
> 
> 
Okay, will be update to:
description: |
The MediaTek mt8196 SoC contains
a DSP core used for advanced pre- and
  post-audio processing. This DSP
is typically used by the Sound Open Firmware
  (SOF) driver and requires
registers, clocks, memory regions, and a mailbox
  for communication.
 
Th
anks.
> > +  pre- and post- audio processing.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt8196-dsp
> > +
> > +  reg:
> > +    items:
> > +      - description: DSP configuration registers
> > +      - description: DSP SRAM
> > +      - description: DSP secure registers
> > +      - description: DSP bus registers
> > +
> > +  reg-names:
> > +    items:
> > +      - const: cfg
> > +      - const: sram
> > +      - const: sec
> > +      - const: bus
> > +
> > +  clocks:
> > +    items:
> > +      - description: mux for dsp clock
> > +      - description: 26M clock
> > +      - description: ADSP PLL clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: adsp_sel
> 
> Isn't this called audiodsp in other bindings?
> 
Yes, but essentially it is the mux selection of the ADSP clock.
So, would using "adsp_sel" make it clearer?

> > +      - const: clk26m
> 
> Don't use frequencies. How is the pin or input called in datasheet?
> How
> other devices call it?
> 
> > +      - const: adsppll
> > +
> > +  power-domains:
> > +    maxItems: 1
> > +
> 
> Best regards,
> Krzysztof