Re: [PATCH] serial: core: fix OF node leak

From: Johan Hovold
Date: Tue Jul 08 2025 - 11:25:23 EST


On Tue, Jul 08, 2025 at 01:37:45PM +0000, Aidan Stewart wrote:
> On Tue, 2025-07-08 at 10:58 +0200, Johan Hovold wrote:

> > Make sure to drop the OF node reference taken when initialising the
> > control and port devices when the devices are later released.
> >
> > Fixes: d36f0e9a0002 ("serial: core: restore of_node information in
> > sysfs")
> > Cc: Aidan Stewart <astewart@xxxxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

> Thanks for the fix. I think this also needs to go into -stable, as the
> previous changes have already landed there (6.12.36 and 6.15.5).

I left out the stable tag on purpose since this leak should not cause
trouble as, for example, these devices are typically registered at boot
and never deregistered.

It fixes an issue introduced in rc4 so it should preferably still go
into 6.16-final, though.

Johan