Re: [PATCH v8 14/24] ACPI: property: Refactor acpi_fwnode_get_reference_args() to support nargs_prop
From: Andy Shevchenko
Date: Mon Jul 07 2025 - 16:39:29 EST
On Fri, Jul 04, 2025 at 12:33:46PM +0530, Anup Patel wrote:
>
> Currently, acpi_fwnode_get_reference_args() delegates to the internal
> function __acpi_node_get_property_reference() to retrieve property
> references. However, this function does not handle the nargs_prop (cells
> property) parameter, and instead expects the number of arguments (nargs)
> to be known or hardcoded.
>
> As a result, when fwnode_property_get_reference_args() is used with a
> valid nargs_prop, the ACPI backend ignores it, whereas the Device Tree
> (DT) backend uses the #*-cells property from the reference node to
> determine the number of arguments dynamically.
>
> To support the nargs_prop in ACPI, refactor the code as follows:
>
> - Move the implementation from __acpi_node_get_property_reference()
> into acpi_fwnode_get_reference_args().
>
> - Update __acpi_node_get_property_reference() to call the (now updated)
> acpi_fwnode_get_reference_args() passing NULL as nargs_prop to keep
> the behavior of __acpi_node_get_property_reference() intact.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
With Best Regards,
Andy Shevchenko