Re: [PATCH] gpio: vortex86: add new GPIO device driver

[Bartosz Golaszewski]

On Mon, Jul 7, 2025 at 3:22 PM Marcos Del Sol Vives <marcos@xxxxxxxx> wrote:
>
> Add a new simple GPIO device driver for Vortex86 lines of SoCs,
> implemented according to their programming reference manual [1].
>
> This is required for detecting the status of the poweroff button and
> performing the poweroff sequence on ICOP eBox computers.
>
> IRQs are not implemented as they are available for less than half the
> GPIO pins, and they are not the ones required for the poweroff stuff, so
> polling will be required anyway.
>
> [1]: http://www.dmp.com.tw/tech/DMP_Vortex86_Series_Software_Programming_Reference_091216.pdf
>
> Signed-off-by: Marcos Del Sol Vives <marcos@xxxxxxxx>
> ---

Hi!

This patch immediately rings alarm bells in my head because the chip
is not registered with the driver model. It's not 2005 anymore so I'd
need some more explanation. IMO there's nothing that makes it
impossible to implement this as a platform device. Could you elaborate
more on why you chose to implement it this way?

Bart