Re: [PATCH v2] media: venus: pm_helpers: use opp-table for the frequency

[Renjiang Han]

On 6/12/2025 10:23 AM, Renjiang Han wrote:
> Some platforms (such as qcs615 and sc7180) use the same core but have
> different frequency tables. Using the opp-table allows us to separate
> the core description from the frequency data and supports the use of
> fallback compatibles.
>
> Reviewed-by: Vikash Garodia<quic_vgarodia@xxxxxxxxxxx>
> Reviewed-by: Bryan O'Donoghue<bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Renjiang Han<quic_renjiang@xxxxxxxxxxx>
> ---
> video core in QCS615 is same as that in SC7180, while the clock frequency
> corners are different. In such cases, the clock frequencies are better
> represented in DT than static table in video driver. The patch make use
> of OPP table in DT to choose the frequency corner to scale.
>
> Note:
> Earlier discussion was concluded in [1] where it was agreed to rely on
> opp-table for QCS615.
>
> [1]https://lore.kernel.org/linux-arm-msm/c9b83c8b-68d1-43bc-99d6-d2d2b9e445f4@xxxxxxxxxxxxxxxx/
> ---
> Changes in v2:
> - 1. Update message based on the review comment.
> - Link to v1:https://lore.kernel.org/r/20250610-use_freq_with_opp_table-v1-1-7339d690fd1a@xxxxxxxxxxx
> ---
>   drivers/media/platform/qcom/venus/pm_helpers.c | 58 +++++++++++++++-----------
>   1 file changed, 34 insertions(+), 24 deletions(-)
I’d appreciate any thoughts you might have on this.

--
Best Regards,
Renjiang