Re: [PATCH v6] staging: media: atomisp: apply clang-format and fix checkpatch.pl errors

From: Andy Shevchenko
Date: Fri Jun 27 2025 - 12:18:25 EST


On Fri, Jun 27, 2025 at 06:05:08PM +0200, Hans de Goede wrote:
> On 27-Jun-25 4:56 PM, LiangCheng Wang wrote:

...

> for (i = 0; i < count; i++) {
> - err = i2c_smbus_write_byte_data(client, reglist[i].reg, reglist[i].val);
> + err = i2c_smbus_write_byte_data(client, reglist[i].reg,
> + reglist[i].val);
> if (err) {
> - dev_err(&client->dev, "write error: wrote 0x%x to offset 0x%x error %d",
>
> The original line here had a length below 100 chars, so it was fine
> and log messages are allowed to go over the length limit

Actually I tend to agree with clang-format on this case and that's why:
until V4L2 becomes less pedantic and fanatic about 80 characters
limit, the 100 is not applicable for this driver to be moved under
their umbrella.

> + dev_err(&client->dev,
> + "write error: wrote 0x%x to offset 0x%x error %d",
> reglist[i].val, reglist[i].reg, err);
> return err;
> }

--
With Best Regards,
Andy Shevchenko