Re: [PATCH 1/2] platform/x86: wmi: Fix WMI event enablement

From: Ilpo Järvinen
Date: Thu Jun 26 2025 - 11:20:49 EST


On Fri, 20 Jun 2025 00:14:39 +0200, Armin Wolf wrote:

> It turns out that the Windows WMI-ACPI driver always enables/disables
> WMI events regardless of whether they are marked as expensive or not.
> This finding is further reinforced when reading the documentation of
> the WMI_FUNCTION_CONTROL_CALLBACK callback used by Windows drivers
> for enabling/disabling WMI devices:
>
> The DpWmiFunctionControl routine enables or disables
> notification of events, and enables or disables data
> collection for data blocks that the driver registered
> as expensive to collect.
>
> [...]


Thank you for your contribution, it has been applied to my local
review-ilpo-fixes branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: wmi: Fix WMI event enablement
commit: cf0b812500e64a7d5e2957abed38c3a97917b34f
[2/2] platform/x86: wmi: Update documentation of WCxx/WExx ACPI methods
commit: 50b6914fc53c718c5426fb6e9cd9484f9ae967c2

--
i.