Re: [PATCH] mfd: rohm-bd71828: Constify some structures

From: Lee Jones
Date: Thu Jun 19 2025 - 08:07:15 EST


On Sun, 15 Jun 2025, Christophe JAILLET wrote:

> Several structures are not modified in this driver. Constifying them moves
> some data to a read-only section, so increases overall security, especially
> when the structure holds some function pointers. This is the case for
> 'gpio_keys_platform_data' and 'mfd_cell'.
>
> On a x86_64, with allmodconfig:
> Before:
> ======
> text data bss dec hex filename
> 18161 14112 192 32465 7ed1 drivers/mfd/rohm-bd71828.o
>
> After:
> =====
> text data bss dec hex filename
> 22897 9376 192 32465 7ed1 drivers/mfd/rohm-bd71828.o
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
> Compile tested only
> ---
> drivers/mfd/rohm-bd71828.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Doesn't apply. Please rebase and resubmit.

--
Lee Jones [李琼斯]