Re: [PATCH v5 2/5] iio: backend: update iio_backend_oversampling_ratio_set

From: Andy Shevchenko
Date: Mon Jun 02 2025 - 11:21:07 EST


On Mon, Jun 02, 2025 at 04:43:40PM +0300, Pop Ioan Daniel wrote:
> Add chan parameter to iio_backend_oversampling_ratio_set() to allow
> for contexts where the channel must be specified. Modify all
> existing users.

...

> static int ad4851_set_oversampling_ratio(struct iio_dev *indio_dev,

> if (ret)
> return ret;
> }

> -

Why do you remove this blank line? To me these two blocks do not look toughly
coupled.

> - ret = iio_backend_oversampling_ratio_set(st->back, osr);
> + /* Channel is ignored by the backend being used here */
> + ret = iio_backend_oversampling_ratio_set(st->back, 0, osr);
> if (ret)
> return ret;

--
With Best Regards,
Andy Shevchenko