Re: [PATCH 0/8] SHA-256 cleanup

[Herbert Xu]

Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> This series restores the SHA-256 code to have a clean design where the
> crypto_shash API is implemented on top of the regular library API
> instead of a special unsafe low-level API.  Diffstat is -41 lines.
> 
> Eric Biggers (8):
>  Revert "crypto: sha256 - Use the partial block API"
>  Revert "crypto: lib/sha256 - Use generic block helper"
>  Revert "crypto: x86/sha256 - Add simd block function"
>  Revert "crypto: riscv/sha256 - Add simd block function"
>  Revert "crypto: arm64/sha256 - Add simd block function"
>  Revert "crypto: arm/sha256 - Add simd block function"
>  Revert "crypto: sha256 - Use the partial block API for generic"
>  Revert "crypto: lib/sha256 - Add helpers for block-based shash"
> 
> arch/arm/lib/crypto/Kconfig         |   1 -
> arch/arm/lib/crypto/sha256-armv4.pl |  20 ++--
> arch/arm/lib/crypto/sha256.c        |  14 +--
> arch/arm64/crypto/sha512-glue.c     |   6 +-
> arch/arm64/lib/crypto/Kconfig       |   1 -
> arch/arm64/lib/crypto/sha2-armv8.pl |   2 +-
> arch/arm64/lib/crypto/sha256.c      |  14 +--
> arch/riscv/lib/crypto/Kconfig       |   1 -
> arch/riscv/lib/crypto/sha256.c      |  13 +--
> arch/x86/lib/crypto/Kconfig         |   1 -
> arch/x86/lib/crypto/sha256.c        |  12 +--
> crypto/sha256.c                     | 142 ++++++++++------------------
> include/crypto/internal/sha2.h      |  52 ++--------
> include/crypto/sha2.h               |   7 +-
> lib/crypto/Kconfig                  |   8 --
> lib/crypto/sha256.c                 |  97 +++++++++++++++----
> 16 files changed, 175 insertions(+), 216 deletions(-)
> 
> 
> base-commit: 1bafd82d9a40cf09c6c40f1c09cc35b7050b1a9f

Nack.  This breaks the cryptodev tree.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt