Re: [PATCH v2 2/7] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support

[Prasad Kumpatla]

On 4/29/2025 4:21 PM, Konrad Dybcio wrote:
> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
> > From: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> >
> > Add WSA LPASS macro Codec along with SoundWire controller.
> >
> > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sc7280.dtsi | 68 ++++++++++++++++++++++++++++
> >   1 file changed, 68 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > index 3453740c0d14..d4aacb97a18c 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > @@ -2601,6 +2601,64 @@
> >   			status = "disabled";
> >   		};
> >   
> > +		lpass_wsa_macro: codec@3240000 {
> > +			compatible = "qcom,sc7280-lpass-wsa-macro";
> > +			reg = <0x0 0x03240000 0x0 0x1000>;
> > +
> > +			clocks = <&lpass_aon LPASS_AON_CC_TX_MCLK_CLK>,
> > +				 <&lpass_aon LPASS_AON_CC_TX_MCLK_2X_CLK>,
> > +				 <&lpass_va_macro>;
> > +			clock-names = "mclk", "npl", "fsgen";
>
> Please make this a vertical list
Ack>
> > +
> > +			pinctrl-names = "default";
> > +			pinctrl-0 = <&lpass_wsa_swr_clk>, <&lpass_wsa_swr_data>;
>
> property-n
> property-names
>
> across all changes, please
>
> [...]
Ack>
> > +		swr2: soundwire@3250000 {
> > +			compatible = "qcom,soundwire-v1.6.0";
> > +			reg = <0x0 0x03250000 0x0 0x2000>;
> > +
> > +			interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&lpass_wsa_macro>;
> > +			clock-names = "iface";
> > +
> > +			resets = <&lpass_audiocc LPASS_AUDIO_SWR_WSA_CGCR>;
> > +			reset-names = "swr_audio_cgcr";
> > +
> > +			qcom,din-ports = <2>;
>
> The computer tells me it should be 3
For swr2 - soundwire version-V1.6.0 contains din-ports as 2 only. Please 
refer below link
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/arch/arm64/boot/dts/qcom/sc8280xp.dtsi#n2931

Thanks,
Prasad>
> Konrad