Re: [PATCH v3 2/2] clk: renesas: r9a09g057: Add clock and reset entries for GBETH0/1

[Geert Uytterhoeven]

Hi Prabhakar,

On Mon, 28 Apr 2025 at 20:42, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Add clock and reset entries for GBETH instances. Include core clocks for
> PTP, sourced from PLLETH, and add PLLs, dividers, and static mux clocks
> used as clock sources for the GBETH IP.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> ---
> v2->v3:
> - Used DEF_MOD_MUX_EXTERNAL() macro for external MUX clocks.
> - Renamed gbe0/1 external mux clock names

Thanks for the update!

> --- a/drivers/clk/renesas/r9a09g057-cpg.c
> +++ b/drivers/clk/renesas/r9a09g057-cpg.c
> @@ -78,6 +87,19 @@ static const struct clk_div_table dtable_2_64[] = {
>         {0, 0},
>  };
>
> +static const struct clk_div_table dtable_2_100[] = {
> +       {0, 2},
> +       {1, 10},
> +       {2, 100},
> +       {0, 0},
> +};
> +
> +/* Mux clock tables */
> +static const char * const smux2_gbe0_rxclk[] = { ".plleth_gbe0", "et0_rxclk" };
> +static const char * const smux2_gbe0_txclk[] = { ".plleth_gbe0", "et0_txclk" };
> +static const char * const smux2_gbe1_rxclk[] = { ".plleth_gbe1", "et1_rxclk" };
> +static const char * const smux2_gbe1_txclk[] = { ".plleth_gbe1", "et1_txclk" };
> +
>  static const struct cpg_core_clk r9a09g057_core_clks[] __initconst = {
>         /* External Clock Inputs */
>         DEF_INPUT("audio_extal", CLK_AUDIO_EXTAL),

This patch starts to LGTM.  The only outstanding issue is how the
et*_[rt]xclk will be provided.  I have read your comments on v2,
and am eagerly awaiting the full patch set (CPG binding update, PHY
updates, ...) to get this all to work.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds