Re: [PATCH v3 3/3] soc: qcom: socinfo: Add support for new fields in revision 22

[Dmitry Baryshkov]

On Thu, May 08, 2025 at 06:42:58PM +0530, Mukesh Ojha wrote:
> Add the ncluster_cores_array_offset field with socinfo structure
> revision 22 which specifies no of cores present in each cluster.
> 
> Signed-off-by: Mukesh Ojha <mukesh.ojha@xxxxxxxxxxxxxxxx>
> ---
> Changes in v3:
>  - Removed debugfs entry as per review comment by [Dmitry B]

Same comment. Please respond to the questions instead of sending next
iteration which is going to be NAKed.

> 
> Changes in v2: https://lore.kernel.org/lkml/20250425135946.1087065-3-mukesh.ojha@xxxxxxxxxxxxxxxx/
>  - Added debugfs entry.
> 
>  drivers/soc/qcom/socinfo.c       | 1 +
>  include/linux/soc/qcom/socinfo.h | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 55acae79ec3a..7ae4c602e3cd 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -608,6 +608,7 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>  			   &qcom_socinfo->info.fmt);
>  
>  	switch (qcom_socinfo->info.fmt) {
> +	case SOCINFO_VERSION(0, 22):
>  	case SOCINFO_VERSION(0, 21):
>  	case SOCINFO_VERSION(0, 20):
>  		qcom_socinfo->info.raw_package_type = __le32_to_cpu(info->raw_package_type);
> diff --git a/include/linux/soc/qcom/socinfo.h b/include/linux/soc/qcom/socinfo.h
> index 3666870b7988..0c12090311aa 100644
> --- a/include/linux/soc/qcom/socinfo.h
> +++ b/include/linux/soc/qcom/socinfo.h
> @@ -86,6 +86,8 @@ struct socinfo {
>  	__le32 raw_package_type;
>  	/* Version 21 */
>  	__le32 nsubpart_feat_array_offset;
> +	/* Version 22 */
> +	__le32 ncluster_cores_array_offset;
>  };
>  
>  /* Internal feature codes */
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry