Re: [PATCH 2/3] clk: qcom: camcc-sc8180x: Add SC8180X camera clock controller driver

[Vladimir Zapolskiy]

On 4/22/25 08:42, Satya Priya Kakitapalli wrote:
> Add support for the camera clock controller for camera clients to
> be able to request for camcc clocks on SC8180X platform.
>
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> ---
>   drivers/clk/qcom/Kconfig         |   10 +
>   drivers/clk/qcom/Makefile        |    1 +
>   drivers/clk/qcom/camcc-sc8180x.c | 2896 ++++++++++++++++++++++++++++++++++++++
>   3 files changed, 2907 insertions(+)
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 7d5dac26b244bfe785370033ad8ba49876d6627d..42b64e34b3fcc4bae7c559f34a34f9452307ae9a 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -900,6 +900,16 @@ config SDX_GCC_75
>   	  Say Y if you want to use peripheral devices such as UART,
>   	  SPI, I2C, USB, SD/eMMC, PCIe etc.
>   
> +config SC_CAMCC_8180X
> +	tristate "SC8180X Camera Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select SC_GCC_8180X
> +	help
> +	  Support for the camera clock controller on Qualcomm Technologies, Inc
> +	  SC8180X devices.
> +	  Say Y if you want to support camera devices and functionality such as
> +	  capturing pictures.
> +
>   config SM_CAMCC_4450
>   	tristate "SM4450 Camera Clock Controller"
>   	depends on ARM64 || COMPILE_TEST

Please add a new config section preserving the alphanumerical order.

The new section should be placed between SC_CAMCC_7280 and SC_CAMCC_8280XP,
like it's correctly done for the Makefile below.

After fixing it:

Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>

--
Best wishes,
Vladimir