Re: [PATCH v8 00/10] Add support for videocc, camcc, dispcc and gpucc on Qualcomm QCS615 platform

From: Krzysztof Kozlowski
Date: Fri Apr 25 2025 - 01:48:42 EST


On 24/04/2025 18:28, Taniya Das wrote:
>
>
> On 4/24/2025 8:59 PM, Krzysztof Kozlowski wrote:
>> On 24/04/2025 13:13, Taniya Das wrote:
>>>
>>>
>>> On 4/24/2025 4:40 PM, Krzysztof Kozlowski wrote:
>>>> On 24/04/2025 11:32, Taniya Das wrote:
>>>>> Add support for multimedia clock controllers on Qualcomm QCS615 platform.
>>>>> Update the defconfig to enable these clock controllers.
>>>>>
>>>>> Global clock controller support
>>>>> https://lore.kernel.org/all/20241022-qcs615-clock-driver-v4-0-3d716ad0d987@xxxxxxxxxxx/
>>>>>
>>>>> Changes in v8:
>>>>> - Drop the properties which are already covered as part of gcc.yaml [Krzysztof]
>>>>> - Drop the RB tag for dt-bindings for Camera clock controller.
>>>>
>>>> Why?
>>>
>>> It had comments, so wanted to share the latest RB-by.
>> So there were some comments and that's the basis to ask to do review
>> twice? So anyone can comment on anything and you will remove people's
>> review? I am not going through this again.
>>
>
> It was your comments, so I thought it would not be good to keep the RB
> tag if it has so many comments. That was the reason to drop it.
I was fine with the binding, then I gave some comments on other
bindings, you implemented these comments and you claim that result:

code already reviewed by me + implemented my comments

could be something I would not consider reviewed. Basically

my review + implemented my comments != my review

I think it means I would be very inconsequential and unpredictable. I
think this is creating unnecessary workload on me, but sure, if that was
the intention I will do the work again.

Best regards,
Krzysztof