Re: [PATCH v4 4/8] dt-bindings: phy: mtk-xs-phy: support type switch by pericfg
From: Frank Wunderlich
Date: Thu Apr 24 2025 - 11:10:42 EST
Am 24. April 2025 09:35:11 MESZ schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>On Tue, Apr 22, 2025 at 03:24:27PM GMT, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>>
>> Add support for type switch by pericfg register between USB3/PCIe.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx>
>> ---
>> v4:
>> - changes based on comments from Krzysztof
>> - change to phy type configuration controller/register
>> ---
>> .../devicetree/bindings/phy/mediatek,xsphy.yaml | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
>> index 3b5253659e6f..0bed847bb4ad 100644
>> --- a/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
>> +++ b/Documentation/devicetree/bindings/phy/mediatek,xsphy.yaml
>> @@ -151,6 +151,21 @@ patternProperties:
>> minimum: 1
>> maximum: 31
>>
>> + mediatek,syscon-type:
>
>Although this should be probably mediatek,phy-type-syscon, because now
>it feels like you define here type of syscon. Anyway, keep Rb tag.
I/Daniel took same property name like for tphy.
Thanks for your opinion,but i hope the series can be merged now :)
>Best regards,
>Krzysztof
>
regards Frank