[PATCH v2 2/2] serdev: Remove repeated device name in dev_(err|dbg) messages

From: Zijun Hu
Date: Thu Apr 24 2025 - 08:25:07 EST


From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>

There are serval dev_err() and dev_dbg() usages shown below:

dev_dbg(dev, "...%s...", dev_name(dev))

The device name is repeated since dev_dbg() also prints device
name as prefix.

Fix by optimizing the messages printed.

Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
---
drivers/tty/serdev/core.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index 971651b8e18dcbb5b7983cdfa19e7d60d4cd292b..f00106de76a0f1e547310c7d21cc2fe3d5869e28 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -118,12 +118,12 @@ int serdev_device_add(struct serdev_device *serdev)

err = device_add(&serdev->dev);
if (err < 0) {
- dev_err(&serdev->dev, "Can't add %s, status %pe\n",
- dev_name(&serdev->dev), ERR_PTR(err));
+ dev_err(&serdev->dev, "Can't add serdev, status %pe\n",
+ ERR_PTR(err));
goto err_clear_serdev;
}

- dev_dbg(&serdev->dev, "device %s registered\n", dev_name(&serdev->dev));
+ dev_dbg(&serdev->dev, "serdev registered successfully\n");

return 0;

@@ -783,8 +783,8 @@ int serdev_controller_add(struct serdev_controller *ctrl)
goto err_rpm_disable;
}

- dev_dbg(&ctrl->dev, "%s registered: dev:%p\n",
- dev_name(&ctrl->dev), &ctrl->dev);
+ dev_dbg(&ctrl->dev, "serdev controller registered: dev:%p\n",
+ &ctrl->dev);
return 0;

err_rpm_disable:

--
2.34.1