Re: [PATCH v6 2/5] dt-bindings: media: Add qcom,x1e80100-camss

From: Bryan O'Donoghue
Date: Thu Apr 24 2025 - 07:30:05 EST


On 24/04/2025 11:45, Dmitry Baryshkov wrote:
Which would then be consistent across SoCs for as long as 0p9 and 1p2 are
the power-domains used by these PHYs.
This won't be consistent with other cases where we have a shared power
pin. For example, for PMICs we provide supply names which match pin
names rather than one-supply-per-LDO.

Yes but taking a random example from a PMIC vdd-l2-l13-l14-supply is specific to a given PMIC, so you need to name it specifically wrt its PMIC pin-name whereas csiphyX-1p2 is there for every CSIPHY we have.

For example on qcom2290 there's a shared power-pin for VDD_A_CAMSS_PLL_1P8 but then individual power-pins for VDD_A_CSI_0_1P2 and VDD_A_CSI_1_1P2.

If we follow the general proposal of

vdd-csiphyX-1p2-supply
vdd-csiphyX-0p9-supply

in the yaml, then whether SoCs like qcm2290 share 1p8 or SoCs like sm8650, sm8450, x1e have individual 1p8 pins is up to the dtsi to decide.

---
bod