Re: [PATCH v0] net: ethtool: Only set supplied eee ethtool settings

[Andrew Lunn]

On Thu, Apr 17, 2025 at 10:12:30AM +1200, Rutger van Kruiningen wrote:
> Originally all ethtool eee setting updates were attempted even if the
> settings were not supplied, causing a null pointer crash.
> 
> Add check for each eee setting and only update if it exists.

I see what you mean, but i'm somewhat surprised we have not seen this
crash. Do you have a simple reproducer? I just did

ethtool --debug 255 --set-eee eth0 eee on

and it did not crash, despite:

sending genetlink packet (44 bytes):
    msg length 44 ethool ETHTOOL_MSG_EEE_SET
    ETHTOOL_MSG_EEE_SET
        ETHTOOL_A_EEE_HEADER
            ETHTOOL_A_HEADER_DEV_NAME = "eth0"
        ETHTOOL_A_EEE_ENABLED = on

So it only provided ETHTOOL_A_EEE_ENABLED and none of the others.

	Andrew