Re: [PATCH 06/10] x86/fpu: Log XSAVE disablement consistently

[Chang S. Bae]

On 4/16/2025 9:56 AM, Sohil Mehta wrote:
> On 4/15/2025 7:16 PM, Chang S. Bae wrote:
> >   static void __init fpu__init_disable_system_xstate(unsigned int legacy_size)
> >   {
> > +	pr_info("x86/fpu: XSAVE disabled\n");
> > +
>
> There is a mix of pr_info(), pr_warn() and pr_err() to log these related
> messages. Would it be useful to make the log level consistent in this
> patch or a follow-up?
>
> I think new the "XSAVE disabled" print should be a pr_warn() at least.

I think pr_info() makes sense here, as it aligns with this hunk:

static __init void disable_smp(void)
{
	pr_info("SMP disabled\n");

	disable_ioapic_support();
	topology_reset_possible_cpus_up();

	cpumask_set_cpu(0, topology_sibling_cpumask(0));
	cpumask_set_cpu(0, topology_core_cpumask(0));
	cpumask_set_cpu(0, topology_die_cpumask(0));
}

If you strongly feel that pr_warn() is more appropriate, then it would 
make sense to update all related messages consistently. But honestly, I 
don’t think it’s a big deal either way.