Re: [PATCH 2/2] net: phy: dp83826: Add support for straps reading
From: Jean-Michel Hautbois
Date: Mon Mar 03 2025 - 12:47:21 EST
Hi Andrew,
On 03/03/2025 18:20, Andrew Lunn wrote:
On Mon, Mar 03, 2025 at 06:05:52PM +0100, Jean-Michel Hautbois wrote:
When the DP83826 is probed, read the straps, and apply the default
settings expected. The MDI-X is not yet supported, but still read the
strap.
What about backwards compatibility? I expect this changes the
behaviour of the device, potentially introducing regressions? Please
add an explanation of why this is safe.
I am not certain it is safe. As far as I know that if straps are used on
the hardware, then it should be used, and if the behavior has to be
different, then userspace can change it (or any other way). Am I wrong ?
How could we make is safer, though ? We somehow need to read those ?
Thanks,
JM
Andrew
---
pw-bot: cr