Re: [PATCH V3 0/3] Add unit test module for AMD P-State driver

From: Shuah Khan
Date: Fri Apr 22 2022 - 13:48:25 EST


On 4/21/22 1:41 AM, Meng Li wrote:
Hi all:

AMD P-State unit test(amd_pstate_testmod) is a kernel module for testing
the functions of amd-pstate driver.
It could import as a module to launch some test tasks.
1) It can help all users to verify their processor support (SBIOS/Firmware
or Hardware).
2) Kernel can have a basic function test to avoid the kernel regression
during the update.
3) We can introduce more functional or performance tests to align the
together, it will benefit power and performance scale optimization.

We upstream out AMD P-state driver into Linux kernel and use this unit
test module to verify the required conditions and basic functions of
amd-pstate before integration test.

We use test module in the kselftest frameworks to implement it.
We create amd_pstate_testmod module and tie it into kselftest.

For example: The test case aput_acpi_cpc is used to check whether the
_CPC object is exist in SBIOS.
The amd-pstate initialization will fail if the _CPC in ACPI SBIOS is not
existed at the detected processor, so it is a necessary condition.

At present, it only implements the basic framework and some simple test
cases.

TODO : 1) we will add a rst document.

Please include document in this series and describe how the test can be run.
It is not clear to me how use should go about running this test especially
since the script depends on a test module which will need to be compiled
and loaded.

I would like to see clear details in the document on the steps involved in
running the test.

2) we will add more test cases to improve the depth and coverage of
the test.

thanks,
-- Shuah