Re: [PATCH v2] staging: unisys: Remove "struct dentry *eth_debugfs_dir"
From: Dan Carpenter
Date: Thu Mar 31 2022 - 04:22:26 EST
On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote:
> There is no need for "struct dentry *eth_debugfs_dir" which is used for
> debug / sysfs directories. Therefore, remove this "struct dentry" and
> everything related (i.e., creation and removal).
>
> As a side effect of this change, the code has no more need of the
> "cleanup_register_netdev" label, which can also be removed.
>
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Suggested-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> ---
>
> v1 - v2: Add a couple of "Suggested-by" tags which were forgotten.
> Thanks to Dan Carpenter and Greg Kroah-Hartman.
>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
regards,
dan carpenter