Re: [PATCH] uapi/linux/stddef.h: add include guards

From: Kees Cook
Date: Wed Mar 30 2022 - 17:49:59 EST


On Tue, Mar 29, 2022 at 10:12:52AM -0700, Tadeusz Struk wrote:
> Add iclude guarde to uapi/linux/stddef.h to prevent
> redefining macros.
>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@xxxxxxxxxx>

Hi!

What was tripping over this? This isn't a new file, so has something
changed with how it has been included?

-Kees

> ---
> include/uapi/linux/stddef.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/uapi/linux/stddef.h b/include/uapi/linux/stddef.h
> index 3021ea25a284..7837ba4fe728 100644
> --- a/include/uapi/linux/stddef.h
> +++ b/include/uapi/linux/stddef.h
> @@ -1,4 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> +#ifndef _UAPI_LINUX_STDDEF_H
> +#define _UAPI_LINUX_STDDEF_H
> +
> #include <linux/compiler_types.h>
>
> #ifndef __always_inline
> @@ -41,3 +44,4 @@
> struct { } __empty_ ## NAME; \
> TYPE NAME[]; \
> }
> +#endif
> --
> 2.35.1
>

--
Kees Cook