Re: [PATCH v2 02/13] gpiolib: Introduce gpiochip_node_count() helper

From: Andy Shevchenko
Date: Wed Mar 30 2022 - 07:35:47 EST


On Wed, Mar 30, 2022 at 12:02:07PM +0200, Geert Uytterhoeven wrote:
> On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > + unsigned int count;
>
> Preinitialize to zero?

Whatever for what consensus will be achieved. Initially I have that way,
then I changed.

> > + count = 0;
> > + for_each_gpiochip_node(dev, child)
> > + count++;
>
> Regardless:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Thanks!

--
With Best Regards,
Andy Shevchenko