Re: [PATCH bpf-next v2 0/4] kprobes: rethook: x86: Replace kretprobe trampoline with rethook

From: Masami Hiramatsu
Date: Fri Mar 25 2022 - 21:10:09 EST


On Fri, 25 Mar 2022 15:43:14 +0100
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Fri, Mar 25, 2022 at 11:22:53PM +0900, Masami Hiramatsu wrote:
>
> > Masami Hiramatsu (3):
> > kprobes: Use rethook for kretprobe if possible
> > rethook: kprobes: x86: Replace kretprobe with rethook on x86
> > x86,kprobes: Fix optprobe trampoline to generate complete pt_regs
> >
> > Peter Zijlstra (1):
> > Subject: x86,rethook: Fix arch_rethook_trampoline() to generate a complete pt_regs
>
> You fat-fingered the subject there ^
>

Oops, I missed to import the patch...

> Other than that:
>
> Acked-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>

Thanks!

>
> Hopefully the ftrace return trampoline can also be switched over..

The rethook clarifies the interfaces for the return trampoline, so
I think this can step the integration forward.


--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>