Re: Question about HFSC atm+man patches

From: Patrick McHardy
Date: Sun Nov 23 2008 - 09:05:48 EST


Michal Soltys wrote:
I'm thinking about writing few simple patches that would introduce layer
2 adaptation to HFSC. Generally - instead of preparing adjusted rate
table like some of the other qdiscs do (tbf, htb, ...), hfsc could
simply adjust packets' lengths in qdisc code (and there are just few places where it's done) - as it's used for all time / curve related computations later. So the whole thing should be, at least in theory, pretty straightforward.

The tc's interface would of course remain the same - that is - linklayer
and overhead options, consistently with other qdiscs.

Would such approach be valid and possibly accepted ?

We already support generic size adjustment for all qdiscs. I'm
not sure about the userspace interface though.

Another thing I'd like to add is detailed tc-hfsc man page (and maybe
add/update other ones - but that's for a bit later).

That would be great.
--
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html