Re: BUG in the PCNET32 ethernet driver

From: Carsten Langgaard (carstenl@mips.com)
Date: Wed Nov 13 2002 - 15:08:08 EST


Jeff Garzik wrote:

> Carsten Langgaard wrote:
>
> > @@ -1316,13 +1316,13 @@
> > if ((newskb = dev_alloc_skb (PKT_BUF_SZ))) {
> > skb_reserve (newskb, 2);
> > skb = lp->rx_skbuff[entry];
> > - pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], skb->len,
> > PCI_DMA_FROMDEVICE);
> > + pci_unmap_single(lp->pci_dev, lp->rx_dma_addr[entry], pkt_len +2,
> > PCI_DMA_FROMDEVICE);
> > skb_put (skb, pkt_len);
> > lp->rx_skbuff[entry] = newskb;
>
> Why does this line not reference PKT_BUF_SZ when all the others do?

In this case we know the size of the packet and therefore only need to handle that.
In the other cases we don't know have big the receiving packet is going to be, so we has to
take care of the whole buffer.

/Carsten

-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html



This archive was generated by hypermail 2b29 : Fri Nov 15 2002 - 22:00:01 EST