Re: [PATCH] ncpfs bug
Petr Vandrovec Ing. VTEI (VANDROVE@vc.cvut.cz)
Tue, 1 Jun 1999 10:49:06 MET-1
On 1 Jun 99 at 10:42, Michael Tross wrote:
> Absolute, you're definitely right. But as I read file.c (v2.2.9), if
> ncp_read() returns without error and read_this_time is ==0, then
> ncp_file_read() breaks out of the loop cause of (read_this_time <
> to_read); but the point is that ncp_file_read() then exits with the
> return code 0. My patch changed this to return an error in this case.
> The ncpfs misbehaviour I described occured in all kernels I have tested
> in the last year, 2.0.32, 2.0.36, 2.2.0 and now 2.2.9. I have LANalyzer
maybe that it is more problem with ncpfs_nopage. It is legal for
*_read filesystem procedure to return with 0 at the end of file (I think,
it is normal behavior for read syscall).
Unfortunately, I do not have access to sources at this moment. But I
changed nopage procedure for 2.2.10-pre1 / 2.3.4 due to possible deadlock.
Maybe I changed this too when walking through code :-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
Please read the FAQ at http://www.tux.org/lkml/