Re: More on 2.1.129 oops
Richard Gooch (email@example.com)
Mon, 23 Nov 1998 23:56:44 +1100
Linus Torvalds writes:
> On Mon, 23 Nov 1998, Richard Gooch wrote:
> > >
> > > Very good. Got the problem. I do not know about a real fix, but a good
> > > workaround would be to remove the "inline" attribute of kernel_thread
> > > in include/asm-i386/unistd.h . Would be nice if you told me if that
> > > fixes the problem (it really should).
> > Well, I was about to do that when I noticed the number of places that
> > kernel_thread() is called.
> That's actually a good argument for it not being inline. And it's not
> timing-critical either.
> I moved "kernel_thread()" into arch/i386/kernel/process.c, and made it a
> real function rather than an inline thing. Does that work for you too?
That also fixes the swapper oops problem. I'm also watching to see if
the oops I got in the route process happens again. So far the machine
has been up for 1:49 without an oops. Fingers crossed.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to firstname.lastname@example.org
Please read the FAQ at http://www.tux.org/lkml/