Re: [PATCH v1 1/1] mm: page_alloc: Avoid defining unused function

From: Andy Shevchenko
Date: Tue Apr 23 2024 - 12:07:37 EST


On Tue, Apr 23, 2024 at 11:55:49AM -0400, Liam R. Howlett wrote:
> * Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> [240423 11:06]:
> > In some configurations I got
> > mm/page_alloc.c:656:20: warning: unused function 'add_to_free_list' [-Wunused-function]
> > Becuase the only user is guarged with a certain ifdeffery,
> > do the same for add_to_free_list().

> Why not relocate it within the existing CONFIG_MEMORY_FAILURE block?

No objections, I'm not familiar with the idea behind this helper.

--
With Best Regards,
Andy Shevchenko