Re: [PATCH 00/14] ASoC: Constify local snd_sof_dsp_ops

From: Krzysztof Kozlowski
Date: Tue Apr 23 2024 - 12:06:32 EST


On 23/04/2024 17:57, Pierre-Louis Bossart wrote:
>
>> Are we talking about basic C now? Of course it does not mean that and I
>> already explained what is the goal of this - the static or global memory
>> in the driver can be moved to rodata.
>
> the dsp_ops used by the Intel drivers cannot be moved to rodata in all
> cases. the baseline is constant, all extensions for TGL+ are dynamically
> allocated and modified.

Yes and these drivers will not benefit. Did I changed them here? I think
I didn't, because then it would not compile.

Can we discuss specific patches in this patchset? Which constifying of
static or global data is not correct, is misleading or is not beneficial
at all?

Best regards,
Krzysztof