Re: [RFC] net: add TCP fraglist GRO support

[Eric Dumazet]

On Tue, Apr 23, 2024 at 2:23 PM Felix Fietkau <nbd@xxxxxxxx> wrote:
>
> On 23.04.24 14:11, Eric Dumazet wrote:
> > On Tue, Apr 23, 2024 at 1:55 PM Felix Fietkau <nbd@xxxxxxxx> wrote:
> >>
> >> In the world of consumer-grade WiFi devices, there are a lot of chipsets
> >> with limited or nonexistent SG support, and very limited checksum
> >> offload capabilities on Ethernet. The WiFi side of these devices is
> >> often even worse. I think fraglist GRO is a decent fallback for the
> >> inevitable corner cases.
> >
> > What about netfilter and NAT ? Are they okay with NETIF_F_FRAGLIST_GRO already ?
> >
> > Many of these devices are probably using NAT.
>
> In my tests, nftables NAT works just fine, both with and without
> flowtable offloading. I didn't see anything in netfilter that would have
> a problem with this.

This is great !