Re: [PATCH v4 9/9] drm/bridge: tfp410: Add platform module alias

From: Krzysztof Kozlowski
Date: Tue Apr 23 2024 - 04:06:56 EST


On 22/04/2024 21:19, Sui Jingfeng wrote:
> Otherwise when compiled as module, this driver will not be probed on
> non-DT environment. This is a fundamential step to make this driver
> truely OF-independent.

NAK.

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.

Just check your aliases and look what is there. You already have
i2c:tfp410 alias. If you need platform one, for some reason, explain
what is your matching path and add appropriate ID table. With that
explanation, of course.

Best regards,
Krzysztof