Re: [PATCH wireless v2] wifi: ath10k: Fix an error code problem in ath10k_dbg_sta_write_peer_debug_trigger()

From: Su Hui
Date: Mon Apr 22 2024 - 21:21:35 EST


On 2024/4/22 14:53, Kalle Valo wrote:
Su Hui <suhui@xxxxxxxxxxxx> writes:

Clang Static Checker (scan-build) Warning:
drivers/net/wireless/ath/ath10k/debugfs_sta.c:line 429, column 3
Value stored to 'ret' is never read.

Return 'ret' rather than 'count' when 'ret' stores an error code.
By the way, remove some useless code.

Fixes: ee8b08a1be82 ("ath10k: add debugfs support to get per peer tids log via tracing")
Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
---
v2:
- remove the initializer change.

drivers/net/wireless/ath/ath10k/debugfs_sta.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/debugfs_sta.c b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
index 394bf3c32abf..c1198e9027ae 100644
--- a/drivers/net/wireless/ath/ath10k/debugfs_sta.c
+++ b/drivers/net/wireless/ath/ath10k/debugfs_sta.c
@@ -432,14 +432,12 @@ ath10k_dbg_sta_write_peer_debug_trigger(struct file *file,
ret = ath10k_wmi_peer_set_param(ar, arsta->arvif->vdev_id, sta->addr,
ar->wmi.peer_param->debug, peer_debug_trigger);
- if (ret) {
+ if (ret)
ath10k_warn(ar, "failed to set param to trigger peer tid logs for station ret: %d\n",
ret);
- goto out;
- }
Minimal changes with one logical change per patch, please. I'll remove
this part in the pending branch.

Sorry for this, thanks for your help!

Su Hui