Re: [PATCH v2,0/5] media: change the calculation method of sizeimage

From: Nicolas Dufresne
Date: Mon Apr 22 2024 - 14:30:17 EST


Hi,

sorry for the long delay.

Le mardi 09 avril 2024 à 14:44 +0800, Yunfei Dong a écrit :
> The bytesperline and sizeimage of each plan are different for 8bit
> and 10bit bitstreams. Using v4l2 common interface to calculate them
> independently.
>
> ---
> compare with v1:
> - add patch 1/2/3/4
> - change the calculation method for sizeimage for patch 5
> ---
> Yunfei Dong (5):
> media: mediatek: vcodec: fix incorrect MT2T format information
> media: mediatek: vcodec: fix incorrect MT2R format information

As per recommandation of the "Submitting Patches":
> On the other hand, if you make a single change to numerous files, group those
> changes into a single patch. Thus a single logical change is contained within
> a single patch.

In general, when two patches have an identical description its a sign they
should be one patch. Would be nice to squash these two.

> media: mediatek: vcodec: add MM21 format definition
> media: mediatek: vcodec: add MT21 format definition

Same.

> media: mediatek: vcodec: fix incorrect sizeimage for 10bit bitstream
>
> .../mediatek/vcodec/decoder/mtk_vcodec_dec.c | 28 ++++++-------------
> drivers/media/v4l2-core/v4l2-common.c | 12 +++++---
> 2 files changed, 16 insertions(+), 24 deletions(-)
>