Re: [PATCH v19 007/130] x86/virt/tdx: Export SEAMCALL functions

From: kirill.shutemov@xxxxxxxxxxxxxxx
Date: Mon Apr 22 2024 - 07:46:52 EST


On Fri, Apr 19, 2024 at 08:04:26PM +0000, Edgecombe, Rick P wrote:
> On Fri, 2024-04-19 at 17:46 +0300, kirill.shutemov@xxxxxxxxxxxxxxx wrote:
> >
> > > Side topic #3, the ud2 to induce panic should be out-of-line.
> >
> > Yeah. I switched to the inline one while debugging one section mismatch
> > issue and forgot to switch back.
>
> Sorry, why do we need to panic?

It panics in cases that should never occur if the TDX module is
functioning properly. For example, TDVMCALL itself should never fail,
although the leaf function could.

--
Kiryl Shutsemau / Kirill A. Shutemov