Re: [PATCH net-next v4 12/12] dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY

From: Parthiban.Veerasooran
Date: Mon Apr 22 2024 - 00:00:45 EST


Hi Conor,

On 18/04/24 9:09 pm, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 06:26:48PM +0530, Parthiban Veerasooran wrote:
>> The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet
>> PHY to enable 10BASE-T1S networks. The Ethernet Media Access Controller
>> (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible
>> with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver
>> integrated into the LAN8650/1. The communication between the Host and the
>> MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial
>> Interface (TC6).
>>
>> Signed-off-by: Parthiban Veerasooran<Parthiban.Veerasooran@xxxxxxxxxxxxx>
>> ---
>> .../bindings/net/microchip,lan865x.yaml | 80 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 81 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/net/microchip,lan865x.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/net/microchip,lan865x.yaml b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml
>> new file mode 100644
>> index 000000000000..4fdec0ba3532
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/microchip,lan865x.yaml
> Filename matching a compatible please.
>
>
OK. Then I will keep the filename as microchip,lan8650.yaml

>> @@ -0,0 +1,80 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id:http://devicetree.org/schemas/net/microchip,lan865x.yaml#
>> +$schema:http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip LAN8650/1 10BASE-T1S MACPHY Ethernet Controllers
>> +
>> +maintainers:
>> + - Parthiban Veerasooran<parthiban.veerasooran@xxxxxxxxxxxxx>
>> +
>> +description:
>> + The LAN8650/1 combines a Media Access Controller (MAC) and an Ethernet
>> + PHY to enable 10BASE‑T1S networks. The Ethernet Media Access Controller
>> + (MAC) module implements a 10 Mbps half duplex Ethernet MAC, compatible
>> + with the IEEE 802.3 standard and a 10BASE-T1S physical layer transceiver
>> + integrated into the LAN8650/1. The communication between the Host and
>> + the MAC-PHY is specified in the OPEN Alliance 10BASE-T1x MACPHY Serial
>> + Interface (TC6).
>> +
>> +allOf:
>> + - $ref: ethernet-controller.yaml#
>> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> Can you use the same referencing style for both elements here please?
>
>
OK. Then I will update this allOf section like below,

allOf:
- $ref: /schemas/net/ethernet-controller.yaml#
- $ref: /schemas/spi/spi-peripheral-props.yaml#

> Otherwise, looks aight to me, so with those fixed:
> Reviewed-by: Conor Dooley<conor.dooley@xxxxxxxxxxxxx>
>
OK. If you agree with the above changes that you expected then I will
add the tag in the next version with the proposed changes.

Best regards,
Parthiban V
> Thanks,
> Conor.
>
>
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: microchip,lan8650
>> + - items:
>> + - const: microchip,lan8651
>> + - const: microchip,lan8650
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + description:
>> + Interrupt from MAC-PHY asserted in the event of Receive Chunks
>> + Available, Transmit Chunk Credits Available and Extended Status
>> + Event.
>> + maxItems: 1
>> +
>> + spi-max-frequency:
>> + minimum: 15000000
>> + maximum: 25000000
>> +
>> + "#address-cells":
>> + const: 1
>> +
>> + "#size-cells":
>> + const: 0
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - spi-max-frequency
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/interrupt-controller/irq.h>
>> + #include <dt-bindings/gpio/gpio.h>
>> +
>> + spi {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + ethernet@0 {
>> + compatible = "microchip,lan8651", "microchip,lan8650";
>> + reg = <0>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&eth0_pins>;
>> + interrupt-parent = <&gpio>;
>> + interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
>> + local-mac-address = [04 05 06 01 02 03];
>> + spi-max-frequency = <15000000>;
>> + };
>> + };
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f41b7f2257d2..2172431a1935 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14378,6 +14378,7 @@ MICROCHIP LAN8650/1 10BASE-T1S MACPHY ETHERNET DRIVER
>> M: Parthiban Veerasooran<parthiban.veerasooran@xxxxxxxxxxxxx>
>> L: netdev@xxxxxxxxxxxxxxx
>> S: Maintained
>> +F: Documentation/devicetree/bindings/net/microchip,lan865x.yaml
>> F: drivers/net/ethernet/microchip/lan865x/lan865x.c
>>
>> MICROCHIP LAN87xx/LAN937x T1 PHY DRIVER
>> --
>> 2.34.1
>>